Conversation
allows the proxy commands to work so i can look at the db from my laptop
we want a delay, so the submit request can cancel a validation request. otherwise, here's not enough time. we kill the delay in forms we haven't configured correctly yet. we figure out a way to handle from error hiding -- it should be the UIs job, not the service layers
we had a bug in the form where the template wouldn't populate damage fields. additionally, we had errors in our weapon db for srd51 for some weapons, which are fixed here.
previously, we would just get into a busy loop trying to stream again and again. instead, we track errors via the db and present different error UIs depending on circumstances
2faa744 to
8097698
Compare
it definitely helps in learnspell and preparespell form with input fields. not sure if it helps in any other case. we added a bunch of ids for ideomorph to hook into anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a few improvements here: